Handle errors when fetching the raw /Metadata (issue 14305) #14340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `Catalog.metadata` getter only handles errors during parsing, however in a *corrupt* PDF document fetching of the raw /Metadata can obviously fail as well. Without this patch the `PDFDocumentProxy.getMetadata` method, in the API, can thus fail which it *never* should and this will cause the viewer to not initialize all state as expected. Fixes one of the documents in issue 14305.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/31b200a25d0b65d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c5dea26a99f3564/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/31b200a25d0b65d/output.txt Total script time: 2.98 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c5dea26a99f3564/output.txt Total script time: 5.52 mins
|
timvandermeij
approved these changes
Dec 4, 2021
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Catalog.metadatagetter only handles errors during parsing, however in a corrupt PDF document fetching of the raw /Metadata can obviously fail as well.Without this patch the
PDFDocumentProxy.getMetadatamethod, in the API, can thus fail which it never should and this will cause the viewer to not initialize all state as expected.Fixes one of the documents in issue #14305.